Add risk_intelligence and event_id to fixtures#5
Merged
Conversation
greenberga
reviewed
Jan 27, 2026
| Timestamp string `json:"timestamp"` | ||
| Origin string `json:"origin"` | ||
|
|
||
| RiskIntelligence null.Value[RiskIntelligenceData] `json:"risk_intelligence,omitempty"` |
There was a problem hiding this comment.
Why is RiskIntelligence here too? I thought it was a sibling of challenge only, not a child as well.
Contributor
Author
There was a problem hiding this comment.
Ah good catch, removed it now
greenberga
reviewed
Jan 27, 2026
| "expectation": { | ||
| "should_accept": true, | ||
| "was_able_to_verify": true, | ||
| "is_client_error": false |
There was a problem hiding this comment.
should there be an event_id as part of this expectation? and the one above it? maybe it's supposed to be like this but i noticed all the ones you added above have one
greenberga
reviewed
Jan 27, 2026
| "is_client_error": false | ||
| "is_client_error": false, | ||
| "event_id": "ev_720d50fd-1e47-4a2d-bc94-f5eeda259f7b", | ||
| "risk_intelligence_value": null |
Contributor
Author
There was a problem hiding this comment.
Ah.. I started out by having the value of risk_intelligence again in the expectations.. Then I figured that the test-runners can just read it from the response value instead - I forgot to clean these two up 👀
greenberga
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
event_idandrisk_intelligencefields to the successfulsiteverifyresponses.Adds sanity tests for the data within the fixtures.
This change should not break any existing SDKs, with these additional fixtures we can be more certain of that.